Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: rename msca -> ma, remove token receiver plugin usage #129

Merged
merged 4 commits into from
Jan 31, 2024
Merged

style: rename msca -> ma, remove token receiver plugin usage #129

merged 4 commits into from
Jan 31, 2024

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented Jan 30, 2024 •
edited
Loading

No description provided.

@howydev howydev changed the title style: rename msca -> ma, remove token receiver plugin usage [draft] style: rename msca -> ma, remove token receiver plugin usage Jan 31, 2024
@howydev howydev changed the title [draft] style: rename msca -> ma, remove token receiver plugin usage style: rename msca -> ma, remove token receiver plugin usage Jan 31, 2024
@howydev howydev changed the title style: rename msca -> ma, remove token receiver plugin usage [draft] style: rename msca -> ma, remove token receiver plugin usage Jan 31, 2024
@howydev howydev force-pushed the howy/rename-msca-to-ma branch from 6850e69 to 93bb92f Compare January 31, 2024 17:46
@howydev howydev changed the title [draft] style: rename msca -> ma, remove token receiver plugin usage style: rename msca -> ma, remove token receiver plugin usage Jan 31, 2024
@howydev howydev requested a review from adam-alchemy January 31, 2024 17:46
adam-alchemy
adam-alchemy approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@adam-alchemy adam-alchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one tiny nit

test/upgrade/LightAccountToMA.t.sol Outdated
contract LightAccountToMSCATest is Test {
IEntryPoint public entryPoint;
IMSCAEntryPoint public mscaEntryPoint;
contract LightAccountToMATest is Test {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should probably say "ModularAccount" in the title to match the phrasing of LightAccount.

@howydev howydev force-pushed the howy/rename-msca-to-ma branch from a59bdee to 8af27be Compare January 31, 2024 21:40
@howydev howydev merged commit ef912fc into develop Jan 31, 2024
3 checks passed
@howydev howydev deleted the howy/rename-msca-to-ma branch January 31, 2024 22:15
howydev added a commit that referenced this pull request Feb 1, 2024
@howydev
style: rename msca -> ma, remove token receiver plugin usage (#129)
46e32bd
howydev added a commit that referenced this pull request Feb 2, 2024
@howydev
style: rename msca -> ma, remove token receiver plugin usage (#129)
f0109c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-alchemy adam-alchemy adam-alchemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howydev @adam-alchemy